[SqlClient] Rename Enrich property #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
github-actions
bot
added
infra
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3080 +/- ##
=======================================
Coverage 70.04% 70.04%
=======================================
Files 429 429
Lines 16838 16838
=======================================
Hits 11794 11794
Misses 5044 5044
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
martincostello
force-pushed
the
gh-3074
branch
from
3abc4e5 to
a07878a
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
force-pushed
the
gh-3074
branch
from
a07878a to
a8e6c9f
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
force-pushed
the
gh-3074
branch
from
a8e6c9f to
49c0494
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
force-pushed
the
gh-3074
branch
from
f491275 to
9b04ebd
Compare
martincostello
force-pushed
the
gh-3074
branch
from
9b04ebd to
e47ccf5
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Member
Author
|
Depends on #3079 |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Remove members from the public API that no nothing on .NET Framework.
Fix-up defines so that redundant code isn't included for .NET Framework.
Generated by `dotnet pack --configuration Release /p:ApiCompatGenerateSuppressionFile=true -p:EnablePackageValidation=true`.
4 spaces, not 2.
Remove members from the public API that no nothing on .NET Framework.
Fix-up defines so that redundant code isn't included for .NET Framework.
Remove members from the public API that no nothing on .NET Framework.
Renames the `Enrich` property to `EnrichWithSqlCommand` and removes the custom event name parameter.
Update signatures in `CompatibilitySuppressions.xml`.
This was referenced Oct 20, 2025
Open
This was referenced Oct 27, 2025
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3074
Changes
Renames the
Enrichproperty toEnrichWithSqlCommandand removes the custom event name parameter.The parameter remains an
objectso it is compatible with bothSystem.Data.SqlClientandMicrosoft.Data.SqlClient.Builds on top of #3079.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes